Suggest completions for newline-delimited type argument properties#62175
Suggest completions for newline-delimited type argument properties#62175mkantor wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
🤖 AI Assistant: Task completed: PR #62175: Suggest completions for newline-delimited type argument properties URL: https://github.c... |
1 similar comment
|
🤖 AI Assistant: Task completed: PR #62175: Suggest completions for newline-delimited type argument properties URL: https://github.c... |
| case SyntaxKind.SemicolonToken: | ||
| case SyntaxKind.CommaToken: | ||
| case SyntaxKind.Identifier: | ||
| case SyntaxKind.StringKeyword: |
There was a problem hiding this comment.
It seems to me this PR focuses on StringKeyword but what about other tokens? Like even the NumberKeyword? And doesn't this change mean that now completions would be suggested at the same line too (like at five: string /*marker*/)?
There was a problem hiding this comment.
Wow, you're right. I must've had a brain fart this morning; I think I read StringKeyword as StringKey and thought it referred to property names, but in retrospect that obviously doesn't make sense (also the original issue and the test case I arbitrarily picked to remove a comma from both happened to have string values). I'll close this for now and reopen with a more general fix when I have a chance. Thanks for the comments.
| //// two: { | ||
| //// three: { | ||
| //// five: string, | ||
| //// five: string |
There was a problem hiding this comment.
You should add a new test case instead of removing the comma from the old one. The old test case is different and it's still worth testing it.
3 participants
Fixes #62117.